Conversation
Contributor
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/cli@0.0.32-pr.263.e9891b4Prefer not to change any import paths? Install using npm alias so your code still imports npm i "base44@npm:@base44-preview/cli@0.0.32-pr.263.e9891b4"Or add it to your {
"dependencies": {
"base44": "npm:@base44-preview/cli@0.0.32-pr.263.e9891b4"
}
}
Preview published to npm registry — try new features instantly! |
Merged
kfirstri
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Description
This PR enables Knip's
classMembersanalysis to detect unused class properties and methods, then removes all unused class members identified by this check. This improves code maintainability by eliminating dead code in error classes and test utilities.Related Issue
Followup for this comment: #249 (comment)
Type of Change
Changes Made
"classMembers"to Knip's include configuration (knip.json:3)getSessionId()method fromErrorReporterclass (src/cli/telemetry/error-reporter.ts:48-55)entityNameproperty fromTypeGenerationErrorclass (src/core/errors.ts:459,472)Base44APIMocktest utility:mockConnectorOAuthStatus(),mockTokenError(),mockUserInfoError()(tests/cli/testkit/Base44APIMock.ts)CLIResultMatchertest utility:toHaveExitCode(),toContainInStdout(),toContainInStderr()(tests/cli/testkit/CLIResultMatcher.ts)Testing
npm test)Checklist
docs/(AGENTS.md) if I made architectural changes (N/A - no architectural changes)Additional Notes
This is a pure cleanup PR that removes dead code without affecting functionality. The Knip configuration change enables ongoing detection of unused class members to prevent future code bloat.
🤖 Generated by Claude | 2026-02-18 14:33 UTC